Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc health interface #1195

Merged
merged 2 commits into from
Mar 25, 2022
Merged

feat: add grpc health interface #1195

merged 2 commits into from
Mar 25, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Add GRPC health interface.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 25, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 25, 2022 07:31
@gaius-qi gaius-qi self-assigned this Mar 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #1195 (d143328) into main (c6c05f6) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

❗ Current head d143328 differs from pull request most recent head fc9935b. Consider uploading reports for the commit fc9935b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   46.49%   46.44%   -0.06%     
==========================================
  Files         133      133              
  Lines       10513    10531      +18     
==========================================
+ Hits         4888     4891       +3     
- Misses       5070     5085      +15     
  Partials      555      555              
Flag Coverage Δ
Object-compatibility-e2etests ∅ <ø> (∅)
e2etests ∅ <ø> (∅)
unittests 46.44% <25.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/rpcserver/rpcserver.go 38.15% <0.00%> (-0.51%) ⬇️
client/daemon/upload/upload_manager.go 54.09% <20.00%> (-3.05%) ⬇️
scheduler/rpcserver/rpcserver.go 25.00% <100.00%> (+3.94%) ⬆️
client/daemon/peer/peertask_conductor.go 57.69% <0.00%> (-0.54%) ⬇️

yxxhero
yxxhero previously approved these changes Mar 25, 2022
Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yxxhero yxxhero merged commit f52be01 into main Mar 25, 2022
@yxxhero yxxhero deleted the feature/health branch March 25, 2022 09:45
@gaius-qi gaius-qi linked an issue Mar 31, 2022 that may be closed by this pull request
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: add grpc health interface

Signed-off-by: Gaius <[email protected]>

* feat: add dfdaemon upload server healthy interface

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add health check endpoint
4 participants