Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscriber data race #1169

Merged
merged 5 commits into from
Mar 18, 2022
Merged

fix: subscriber data race #1169

merged 5 commits into from
Mar 18, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Mar 18, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner March 18, 2022 03:12
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #1169 (df0c8b4) into main (59dad99) will increase coverage by 0.11%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
+ Coverage   46.07%   46.18%   +0.11%     
==========================================
  Files         132      132              
  Lines       10238    10239       +1     
==========================================
+ Hits         4717     4729      +12     
+ Misses       4977     4963      -14     
- Partials      544      547       +3     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.18% <50.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/rpcserver/subscriber.go 59.37% <50.00%> (+5.69%) ⬆️
client/daemon/peer/peertask_conductor.go 57.36% <0.00%> (+0.35%) ⬆️
scheduler/service/service.go 87.31% <0.00%> (+0.86%) ⬆️

gaius-qi
gaius-qi previously approved these changes Mar 18, 2022
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Jim Ma <[email protected]>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit 57aabb2 into main Mar 18, 2022
@gaius-qi gaius-qi deleted the fix/subscriber-data-race branch March 18, 2022 06:08
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
* fix: subscriber data race

Signed-off-by: Jim Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants