-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement grpc client side sync pieces #1167
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Signed-off-by: Jim Ma <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
+ Coverage 46.12% 46.38% +0.25%
==========================================
Files 132 133 +1
Lines 10239 10472 +233
==========================================
+ Hits 4723 4857 +134
- Misses 4968 5061 +93
- Partials 548 554 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gaius-qi
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
244372610
approved these changes
Mar 23, 2022
gaius-qi
pushed a commit
that referenced
this pull request
Jun 28, 2023
* feat: implement grpc client side sync pieces Signed-off-by: Jim Ma <[email protected]> * fix: client unit test Signed-off-by: Jim Ma <[email protected]> * chore: report sync piece error Signed-off-by: Jim Ma <[email protected]> * chore: optimize pieceTaskSyncManager cancel Signed-off-by: Jim Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jim Ma [email protected]
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist