Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: scheduler change piece cost from nanosecond to millisecond #1119

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Mar 4, 2022

Signed-off-by: Gaius [email protected]

Description

  • Scheduler change piece cost from nanosecond to millisecond.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Mar 4, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner March 4, 2022 03:32
@gaius-qi gaius-qi self-assigned this Mar 4, 2022
hyy0322
hyy0322 previously approved these changes Mar 4, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1119 (e483e19) into main (d1b8ee6) will increase coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1119      +/-   ##
==========================================
+ Coverage   45.98%   46.00%   +0.02%     
==========================================
  Files         130      130              
  Lines       10000    10000              
==========================================
+ Hits         4598     4600       +2     
+ Misses       4882     4880       -2     
  Partials      520      520              
Flag Coverage Δ
unittests 46.00% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/cdn.go 61.98% <0.00%> (ø)
pkg/util/timeutils/time_utils.go 66.66% <100.00%> (ø)
scheduler/service/service.go 87.19% <100.00%> (ø)
client/daemon/peer/piece_broker.go 88.88% <0.00%> (+7.40%) ⬆️

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaius-qi gaius-qi merged commit cb68a17 into main Mar 4, 2022
@gaius-qi gaius-qi deleted the feature/piece-cost branch March 4, 2022 06:35
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: change picec cost from nanoseconds to milliseconds

Signed-off-by: Gaius <[email protected]>

* test: scheduler service

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants