Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add content length for fast stream peer task #1061

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

jim3ma
Copy link
Member

@jim3ma jim3ma commented Feb 11, 2022

Signed-off-by: Jim Ma [email protected]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jim3ma jim3ma requested a review from a team as a code owner February 11, 2022 07:35
@codecov-commenter
Copy link

Codecov Report

Merging #1061 (88fecd2) into main (fed4f56) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1061   +/-   ##
=======================================
  Coverage   45.79%   45.79%           
=======================================
  Files         129      129           
  Lines        9542     9546    +4     
=======================================
+ Hits         4370     4372    +2     
- Misses       4679     4680    +1     
- Partials      493      494    +1     
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 45.79% <50.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/daemon/peer/peertask_stream.go 64.28% <50.00%> (-0.43%) ⬇️

Copy link

@hyy0322 hyy0322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit 3403d3b into main Feb 11, 2022
@jim3ma jim3ma deleted the chore/stream-peer-task branch February 11, 2022 08:39
gaius-qi pushed a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants