Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cdn download tiny file #1040

Merged
merged 3 commits into from
Jan 25, 2022
Merged

feat: cdn download tiny file #1040

merged 3 commits into from
Jan 25, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Support cdn download tiny file with range header

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Jan 25, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner January 25, 2022 06:53
@gaius-qi gaius-qi self-assigned this Jan 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #1040 (95531c1) into main (7e3d6d0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1040      +/-   ##
==========================================
- Coverage   46.42%   46.40%   -0.03%     
==========================================
  Files         130      130              
  Lines        9359     9348      -11     
==========================================
- Hits         4345     4338       -7     
+ Misses       4526     4522       -4     
  Partials      488      488              
Flag Coverage Δ
Object-compatibility-e2etests ?
e2etests ?
unittests 46.40% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/resource/cdn.go 66.95% <ø> (+5.84%) ⬆️
scheduler/resource/peer.go 76.72% <100.00%> (ø)
scheduler/service/callback.go 72.36% <100.00%> (ø)
cdn/supervisor/progress/progress.go 91.04% <0.00%> (-5.98%) ⬇️
client/daemon/peer/peertask_conductor.go 56.90% <0.00%> (-0.37%) ⬇️

@gaius-qi gaius-qi force-pushed the feature/cdn-tiny branch 4 times, most recently from 0250d8f to 621a7ae Compare January 25, 2022 09:16
scheduler/resource/peer.go Show resolved Hide resolved
scheduler/resource/peer.go Show resolved Hide resolved
@dragonflyoss dragonflyoss deleted a comment from 244372610 Jan 25, 2022
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jim3ma jim3ma merged commit c552a0c into main Jan 25, 2022
@jim3ma jim3ma deleted the feature/cdn-tiny branch January 25, 2022 12:35
gaius-qi added a commit that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants