-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: register task with size scope #1003
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <[email protected]>
hyy0322
previously approved these changes
Jan 18, 2022
Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/register-task
branch
from
January 18, 2022 04:28
7900cb4
to
1c776cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1003 +/- ##
=======================================
Coverage 45.62% 45.62%
=======================================
Files 128 128
Lines 9101 9101
=======================================
Hits 4152 4152
Misses 4479 4479
Partials 470 470
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jim3ma
previously approved these changes
Jan 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
244372610
previously approved these changes
Jan 18, 2022
…e/register-task Signed-off-by: Gaius <[email protected]>
gaius-qi
force-pushed
the
feature/register-task
branch
from
January 18, 2022 07:33
8c0dd2b
to
c76c7d3
Compare
gaius-qi
added a commit
that referenced
this pull request
Jun 28, 2023
* feat: register task with size scope Signed-off-by: Gaius <[email protected]> * test: fix peer manager data race Signed-off-by: Gaius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Gaius [email protected]
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: