Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: register task with size scope #1003

Merged
merged 3 commits into from
Jan 18, 2022
Merged

fix: register task with size scope #1003

merged 3 commits into from
Jan 18, 2022

Conversation

gaius-qi
Copy link
Member

Signed-off-by: Gaius [email protected]

Description

  • Register task with size scope.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist:

  • Code compiles correctly.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@gaius-qi gaius-qi added this to the v2.0.2 milestone Jan 17, 2022
@gaius-qi gaius-qi requested a review from a team as a code owner January 17, 2022 13:38
@gaius-qi gaius-qi self-assigned this Jan 17, 2022
hyy0322
hyy0322 previously approved these changes Jan 18, 2022
@gaius-qi gaius-qi force-pushed the feature/register-task branch from 7900cb4 to 1c776cd Compare January 18, 2022 04:28
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #1003 (c76c7d3) into main (8aecb35) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1003   +/-   ##
=======================================
  Coverage   45.62%   45.62%           
=======================================
  Files         128      128           
  Lines        9101     9101           
=======================================
  Hits         4152     4152           
  Misses       4479     4479           
  Partials      470      470           
Flag Coverage Δ
unittests 45.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
scheduler/rpcserver/rpcserver.go 85.51% <100.00%> (ø)

jim3ma
jim3ma previously approved these changes Jan 18, 2022
Copy link
Member

@jim3ma jim3ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

244372610
244372610 previously approved these changes Jan 18, 2022
@gaius-qi gaius-qi dismissed stale reviews from 244372610 and jim3ma via 8c0dd2b January 18, 2022 07:29
@gaius-qi gaius-qi force-pushed the feature/register-task branch from 8c0dd2b to c76c7d3 Compare January 18, 2022 07:33
@gaius-qi gaius-qi merged commit 641a65e into main Jan 18, 2022
@gaius-qi gaius-qi deleted the feature/register-task branch January 18, 2022 07:59
gaius-qi added a commit that referenced this pull request Jun 28, 2023
* feat: register task with size scope

Signed-off-by: Gaius <[email protected]>

* test: fix peer manager data race

Signed-off-by: Gaius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants