This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
[SRM-702] Fix for revision loading throws error on illegal offset type. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MdNadimHossain
requested review from
anthony-malkoun,
krakerag,
mayurngondhkar and
vincent-gao
govindmaloo
reviewed
Mar 3, 2023
| @@ -234,8 +234,7 @@ protected function getCurrentNode() : ?NodeInterface { | |||
| if ($route_name === 'entity.node.revision') { | |||
| try { | |||
| $vid = $this->routeMatch->getParameter('node_revision'); | |||
There was a problem hiding this comment.
This will directly return the node revision entity post Drupal 9.3.x
There was a problem hiding this comment.
@govindmaloo just saw your PRs, make sense, thanks for the change. I will put them in testing and merge them for the next release
|
Hey @govindmaloo I have updated the code, please have a look |
MdNadimHossain
requested review from
mayurngondhkar and
govindmaloo
and removed request for
govindmaloo
vincent-gao
approved these changes
Mar 7, 2023
MdNadimHossain
deleted the
bug/SRM-702-revision-throws-error-illegal-offset-type-fix
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://digital-vic.atlassian.net/browse/SRM-702
Issue
Some of the $vid values returned as object and which causes illegal offset type error when calling the
loadRevisionfunction.Scenario - Go to a node in any CMS and click on the revision tab. Then click on any previous revision and then the CMS will throw error.
Changes
9.4 returns the vid directly from here -
$revision = $this->routeMatch->getParameter('node_revision');#121