Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

req.connection.address is not a function #39

Closed
jguepin opened this issue Feb 12, 2018 · 1 comment
Closed

req.connection.address is not a function #39

jguepin opened this issue Feb 12, 2018 · 1 comment

Comments

@jguepin
Copy link

jguepin commented Feb 12, 2018

I am using the bugsnag error middleware to report errors with Express.
The middleware makes serverless-http crash, as req.connection.address() is not defined.

Maybe serverless-http could implement this method, as other Express/Connect middlewares probably use it?

See bugsnag/bugsnag-node#129 for details about the error.

@dougmoscrop
Copy link
Owner

Looks like you already added defensive code for this but I stubbed address() as of 1.5.4 -- not sure if it's properly stubbed, but the port is there (hardcoded to 443).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants