Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi release: every second job fails with an artifact conflict #167

Closed
torymur opened this issue Feb 3, 2025 · 3 comments
Closed

PyPi release: every second job fails with an artifact conflict #167

torymur opened this issue Feb 3, 2025 · 3 comments
Assignees
Labels
bug Something isn't working CI

Comments

@torymur
Copy link
Contributor

torymur commented Feb 3, 2025

Pypi release required 4 restarts of failed jobs to finish: https://github.com/dottxt-ai/outlines-core/actions/runs/13079996880

On each restart attempt any first job will succeed and after that any second job will fail with:

Run actions/upload-artifact@v4
  with:
    path: ./wheelhouse/*.whl
    name: wheels
    if-no-files-found: warn
    compression-level: 6
    overwrite: false
    include-hidden-files: false
  env:
    pythonLocation: /Users/runner/hostedtoolcache/Python/3.10.11/arm64
    PKG_CONFIG_PATH: /Users/runner/hostedtoolcache/Python/3.10.11/arm64/lib/pkgconfig
    Python_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.10.11/arm64
    Python[2](https://github.com/dottxt-ai/outlines-core/actions/runs/13079996880/job/36501173111#step:8:2)_ROOT_DIR: /Users/runner/hostedtoolcache/Python/[3](https://github.com/dottxt-ai/outlines-core/actions/runs/13079996880/job/36501173111#step:8:3).10.11/arm64
    Python3_ROOT_DIR: /Users/runner/hostedtoolcache/Python/3.10.11/arm6[4](https://github.com/dottxt-ai/outlines-core/actions/runs/13079996880/job/36501173111#step:8:4)
With the provided path, there will be 8 files uploaded
Artifact name is valid!
Root directory input is valid!
Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

When we were using actions/upload-artifact and actions/upload-artifact of v3 we didn't have this issue, we had to upgrade to v4, since v3 was deprecated: #161

@torymur torymur added bug Something isn't working CI labels Feb 3, 2025
@torymur torymur self-assigned this Feb 3, 2025
@torymur
Copy link
Contributor Author

torymur commented Feb 3, 2025

According to this: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Several behavioral differences exist between Artifact actions v3 and below vs v4

  • In v3, Artifacts are mutable so it's possible to write workflow scenarios where multiple jobs upload to the same Artifact
  • In v4, Artifacts are immutable (unless deleted).

@torymur
Copy link
Contributor Author

torymur commented Feb 3, 2025

And it also uploaded wheels only from the last job: https://pypi.org/project/outlines-core/0.2.2/#files

@torymur
Copy link
Contributor Author

torymur commented Feb 4, 2025

Closed by #169

@torymur torymur closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

No branches or pull requests

1 participant