Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample (& doc update) that uses simpler Asp.net template format #937

Closed
samsp-msft opened this issue Apr 22, 2021 · 5 comments · Fixed by #1018 or #1287
Closed

Sample (& doc update) that uses simpler Asp.net template format #937

samsp-msft opened this issue Apr 22, 2021 · 5 comments · Fixed by #1018 or #1287
Labels
Type: Documentation Improvements or additions to documentation
Milestone
Backlog

Comments

@samsp-msft
Copy link
Member

.NET 6 preview 4 is set to contain a new simpler template for web sites. We should have a sample (and docs) that show how to use YARP with the simpler template.
@samsp-msft samsp-msft added the Type: Enhancement New feature or request label Apr 22, 2021
@Tratcher Tratcher added this to the YARP 1.0.0 milestone May 6, 2021
@Tratcher
Copy link
Member

Waiting for the preview 4 sdk update here: #972

@MihaZupan MihaZupan removed the Blocked label May 21, 2021
@MihaZupan
Copy link
Member

Should now be unblocked.

@MihaZupan
Copy link
Member

@samsp-msft did you have another sample project in mind or updating an existing sample (e.g. BasicYarpSample)?

@Tratcher
Copy link
Member

This should be its own sample since it will only work on 6.0. See:
https://github.com/dotnet/aspnetcore/blob/main/src/ProjectTemplates/Web.ProjectTemplates/content/EmptyWeb-CSharp/Program.cs

@MihaZupan MihaZupan self-assigned this May 21, 2021
@MihaZupan MihaZupan mentioned this issue May 21, 2021
Merged
@ghost ghost closed this as completed in #1018 May 25, 2021
@MihaZupan MihaZupan removed their assignment May 25, 2021
@MihaZupan
Copy link
Member

Keeping this open as a tracking issue to update the Getting Started docs once 6.0 is released (behavior of dotnet new web changed to use the minimal sample)

@MihaZupan MihaZupan reopened this May 25, 2021
@MihaZupan MihaZupan added Type: Documentation Improvements or additions to documentation and removed Type: Enhancement New feature or request labels May 25, 2021
@samsp-msft samsp-msft mentioned this issue Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
Backlog
3 participants
@Tratcher @MihaZupan @samsp-msft