Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test YARP against .NET 6 previews #936

Closed
samsp-msft opened this issue Apr 22, 2021 · 2 comments · Fixed by #972
Closed

Test YARP against .NET 6 previews #936

samsp-msft opened this issue Apr 22, 2021 · 2 comments · Fixed by #972
Assignees
Labels
Type: Task A task that needs to be completed.
Milestone

Comments

@samsp-msft
Copy link
Member

Although there shouldn't be any changes in .NET 6 that break YARP, we should add .NET 6 as a target for build validation

@samsp-msft samsp-msft added the Type: Task A task that needs to be completed. label Apr 22, 2021
@Tratcher
Copy link
Member

We'll start with tests and samples. We don't want to add a .NET 6 target to the shipping packages until after 1.0.

@Tratcher Tratcher changed the title Build YARP against .NET 6 previews Test YARP against .NET 6 previews Apr 22, 2021
@Tratcher
Copy link
Member

We'll also need to review #if's in the tests and product code to make sure we're using the new NET5_0_OR_GREATER symbols so we don't have to add 6.0 specific symbols.
https://github.com/dotnet/designs/blob/be793b557255c9ed1276ecdd23119b64f45453bf/accepted/2020/or-greater-defines/or-greater-defines.md

This was referenced May 3, 2021
@Tratcher Tratcher added this to the YARP 1.0.0 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Task A task that needs to be completed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants