Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeDomSerializationStore in not marked as Serializable #1831

Closed
MrB0nd opened this issue Sep 9, 2019 · 3 comments
Closed

CodeDomSerializationStore in not marked as Serializable #1831

MrB0nd opened this issue Sep 9, 2019 · 3 comments
Labels
tracking-external-issue An issue is caused by an external system and won't be fixed in this repo won't fix-by design Behaviour is by design

Comments

@MrB0nd
Copy link

MrB0nd commented Sep 9, 2019

  • .NET Core Version: 3.0.100-preview9-014004
  • Have you experienced this same bug with .NET Framework?: No

We faced a problem when porting our application to .NET Core 3. We have a copy/paste functionality which is implemented similar to the standard copy/paste (via IDesignerSerializationService).
On copying we get the SerializationException:
'Type System.ComponentModel.Design.Serialization.CodeDomComponentSerializationService + CodeDomSerializationStore' in Assembly 'System.Windows.Forms.Design, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' is not marked as serializable.'

Сan we expect the attribute to appear in the next release?

@RussKie
Copy link
Member

RussKie commented Sep 9, 2019

The serialisation was removed in #1425.

@Tanya-Solyanik the list of types that should still be serialisable includes System.ComponentModel.Design.Serialization.CodeDomComponentSerializationService.CodeDomSerializationStore (#889 (comment)) however it appears to have been marked as non serialisable:
44b5076#diff-9b75c5f1a3a9a26efe5f949b35d2b0b0L231-L232

Was this intentional or accidental?

@RussKie RussKie added won't fix-by design Behaviour is by design tracking-external-issue An issue is caused by an external system and won't be fixed in this repo and removed needs-more-info labels Sep 9, 2019
@RussKie
Copy link
Member

RussKie commented Sep 9, 2019

This serialization mechanism has had serious maintenance and security concerns in the past.
The Core designer will not put binary content on the clipboard, and hence the attribute was removed.

@RussKie RussKie closed this as completed Sep 9, 2019
@RussKie
Copy link
Member

RussKie commented Sep 9, 2019

Here's the list of types that are no longer serialisable in Windows Forms going forward dotnet/docs#14175
You may also find this post useful https://docs.microsoft.com/en-us/dotnet/standard/serialization/binary-serialization

@Tanya-Solyanik Tanya-Solyanik removed their assignment Sep 27, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tracking-external-issue An issue is caused by an external system and won't be fixed in this repo won't fix-by design Behaviour is by design
Projects
None yet
Development

No branches or pull requests

3 participants