Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

System.Windows.Forms and S.W.F.Design should test round trip between framework versions #1549

Closed
Tanya-Solyanik opened this issue Aug 1, 2019 · 1 comment
Closed

System.Windows.Forms and S.W.F.Design should test round trip between framework versions #1549

Tanya-Solyanik opened this issue Aug 1, 2019 · 1 comment
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization test-enhancement Improvements of test source code

Comments

@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Aug 1, 2019 •
edited
Loading

Existing tests verify:

  1. integration scenarios where resources that are generated on .Net framework are read on Core
  2. test for presence of Serializable attribute on the known types and only on the known types
  3. roundtrip within Core 3.0 and compare resulting blob against .Net

The missing test is to deserialize hardcoded Core content on .Net Framework.
The existing round-trip test should be extracted into a new multi-targeted assembly and tests should run once on Core and once on .Net. Similar issue will be applicable when we have multiple version of Core framework
@Tanya-Solyanik Tanya-Solyanik changed the title System.Windows.Forms and S.W.F.Design should test round trip between framework versions when new frameworks are available System.Windows.Forms and S.W.F.Design should test round trip between framework versions Aug 1, 2019
This was referenced Aug 1, 2019
Merged
Merged
@merriemcgaw merriemcgaw added the test-enhancement Improvements of test source code label Aug 9, 2019
@merriemcgaw merriemcgaw added this to the 3.1 milestone Aug 9, 2019
@merriemcgaw merriemcgaw modified the milestones: 3.1, 5.0 Oct 17, 2019
@RussKie RussKie modified the milestones: 5.0 Previews 1-4, 5.0 Apr 20, 2020
@merriemcgaw merriemcgaw modified the milestones: 5.0, 6.0 Preview1 Sep 1, 2020
@RussKie RussKie modified the milestones: 6.0 Preview1, 6.0 Preview2, 6.0 Jan 27, 2021
@RussKie RussKie modified the milestones: 6.0, 7.0 Aug 27, 2021
@merriemcgaw merriemcgaw modified the milestones: .NET 7.0, .NET 8.0 Aug 11, 2022
@JeremyKuhne JeremyKuhne added the area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization label Aug 16, 2023
@JeremyKuhne
Copy link
Member

The BinaryFormatter work and tests is giving us additional coverage. The risk is low that we'll break serializing for .NET Framework so this isn't worth pursuing.

@ghost ghost removed this from the .NET 8.0 milestone Aug 16, 2023
@JeremyKuhne JeremyKuhne closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Serialization-BinaryFormatter-FeatureWork Feature work under the general area of BinaryFormatter related serialization test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@RussKie @JeremyKuhne @Tanya-Solyanik @merriemcgaw