From deeae484ea3ec55045df84a8addec92ed8a11faf Mon Sep 17 00:00:00 2001
From: Lachlan Ennis <2433737+elachlan@users.noreply.github.com>
Date: Thu, 26 Jan 2023 14:17:25 +1000
Subject: [PATCH] changes from review
---
src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt | 2 +-
.../Design/Serialization/DesignerSerializationManager.cs | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt b/src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt
index 451a1bea97d..33f036622d4 100644
--- a/src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt
+++ b/src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt
@@ -636,7 +636,7 @@ virtual System.ComponentModel.Design.DesignerCommandSet.GetCommands(string! name
~virtual System.ComponentModel.Design.Serialization.CodeDomSerializer.SerializeMemberAbsolute(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, object owningObject, System.ComponentModel.MemberDescriptor member) -> System.CodeDom.CodeStatementCollection
~virtual System.ComponentModel.Design.Serialization.CollectionCodeDomSerializer.SerializeCollection(System.ComponentModel.Design.Serialization.IDesignerSerializationManager manager, System.CodeDom.CodeExpression targetExpression, System.Type targetType, System.Collections.ICollection originalCollection, System.Collections.ICollection valuesToSerialize) -> object
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.CreateInstance(System.Type! type, System.Collections.ICollection? arguments, string? name, bool addToContainer) -> object!
-virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetService(System.Type? serviceType) -> object?
+virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetService(System.Type! serviceType) -> object?
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.GetType(string? typeName) -> System.Type?
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnResolveName(System.ComponentModel.Design.Serialization.ResolveNameEventArgs! e) -> void
virtual System.ComponentModel.Design.Serialization.DesignerSerializationManager.OnSessionCreated(System.EventArgs! e) -> void
diff --git a/src/System.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs b/src/System.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs
index 5bd8f07ca0f..8655c6614b0 100644
--- a/src/System.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs
+++ b/src/System.Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/DesignerSerializationManager.cs
@@ -524,7 +524,7 @@ public IDisposable CreateSession()
///
/// Provides access to the underlying IServiceProvider
///
- protected virtual object? GetService(Type? serviceType)
+ protected virtual object? GetService(Type serviceType)
=> serviceType == typeof(IContainer) ? Container : provider?.GetService(serviceType);
///