From 855ab9529869fc1c5987c531ec05bca67028fff9 Mon Sep 17 00:00:00 2001
From: Viktor Hofer <viktor.hofer@microsoft.com>
Date: Thu, 10 Aug 2023 08:32:54 +0200
Subject: [PATCH] Remove System.Security.Principal.Windows reference (#5229)

* Remove System.Security.Principal.Windows reference

System.Security.Principal.Windows's package shouldn't be referenced anymore as it got ingested into the .NETCoreApp shared framework with .NET 6.

* Update Versions.props

* Update System.ServiceModel.NetFramingBase.csproj
---
 eng/Versions.props                                           | 1 -
 .../src/System.ServiceModel.NetFramingBase.csproj            | 5 -----
 2 files changed, 6 deletions(-)

diff --git a/eng/Versions.props b/eng/Versions.props
index d527047ea2c..671b337a94a 100644
--- a/eng/Versions.props
+++ b/eng/Versions.props
@@ -25,7 +25,6 @@
   <!-- CoreFx dependencies -->
   <PropertyGroup>
     <SystemReflectionDispatchProxyPackageVersion>4.7.1</SystemReflectionDispatchProxyPackageVersion>
-    <SystemSecurityPrincipalWindowsPackageVersion>5.0.0</SystemSecurityPrincipalWindowsPackageVersion>
     <SystemSecurityCryptographyXmlPackageVersion>6.0.1</SystemSecurityCryptographyXmlPackageVersion>
     <MicrosoftExtensionsObjectPoolVersion>6.0.16</MicrosoftExtensionsObjectPoolVersion>
   </PropertyGroup>
diff --git a/src/System.ServiceModel.NetFramingBase/src/System.ServiceModel.NetFramingBase.csproj b/src/System.ServiceModel.NetFramingBase/src/System.ServiceModel.NetFramingBase.csproj
index 8469d6632fd..d3d2759e054 100644
--- a/src/System.ServiceModel.NetFramingBase/src/System.ServiceModel.NetFramingBase.csproj
+++ b/src/System.ServiceModel.NetFramingBase/src/System.ServiceModel.NetFramingBase.csproj
@@ -6,7 +6,6 @@
     <CLSCompliant>true</CLSCompliant>
     <IsPackable>true</IsPackable>
     <IsShipping>$(Ship_WcfPackages)</IsShipping>
-	<!-- TODO: Make this net462 and netstandard2.0 after it's multi-targetting .NET Framework -->
     <TargetFramework>net6.0</TargetFramework>
     <RootNamespace>System.ServiceModel</RootNamespace>
     <DebugType>full</DebugType>
@@ -18,10 +17,6 @@
     <ProjectReference Include="..\..\System.ServiceModel.Primitives\src\System.ServiceModel.Primitives.csproj" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageReference Include="System.Security.Principal.Windows" Version="$(SystemSecurityPrincipalWindowsPackageVersion)" />
-  </ItemGroup>
-
   <!--The default source produced by the Arcade SDK does not work with the checked-in source file SR.cs (class/namespace/filename)-->
   <ItemGroup>
     <EmbeddedResource Update="Resources\Strings.resx">