Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text editors indentation settings are ignored #2918

Closed
WebFreak001 opened this issue Mar 18, 2019 · 1 comment
Closed

Text editors indentation settings are ignored #2918

WebFreak001 opened this issue Mar 18, 2019 · 1 comment

Comments

@WebFreak001
Copy link

Environment data

dotnet --info output: dotnet core not installed
VS Code version: 1.32.3 (user setup)
C# Extension version: 1.17.1

Steps to reproduce

  1. Open a document
  2. Convert indentation using vscode's indentation settings in the status bar

image

  1. Format the document

image

Expected behavior

I expect OmniSharp to format the document using the settings I have configured just now.

Actual behavior

OmniSharp seems to always indent using tabs.

While I prefer tabs better too, some source files have already existing formatting using spaces. I don't think it's a good idea if OmniSharp just ignores the user's settings here. This also breaks with other plugins editing code relying on the current indentation. Even built-in stuff like pressing tab to indent and the snippets are affected by this. I think the format settings in the status bar should be the ultimate source of truth and not be overridable by any other settings as they are determined by vscode with all relevant settings in mind.

There are #1632 #1574 #1290 #93 which are all closed and supposed to fix indentation for over a year, however using the latest version this is still happening.

Tried on Windows and Linux

@JoeRobich
Copy link
Member

O# formatting is controlled first by any applicable .editorconfig, then by settings in omnisharp.json, then by settings in the IDE. It seems that formatting options are being set prior to the falling back to the IDE settings.

@JoeRobich JoeRobich closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants