You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, eng/SourceBuild.props contains <GitHubRepositoryName>source-build</GitHubRepositoryName>. In theory, we could grab that from the git remote config through sourcelink.
But:
If this goes wrong, we end up publishing a package with a bad name to the feed. Still Microsoft.SourceBuild.Intermediate.<something>, so not untraceable, and not something that will break the world, but these are the stakes.
We would have to depend on some internal repo name -> public repo name translation, since they're different.
It would make it harder to repro locally if remotes aren't set up how sourcelink wants them.
How does this affect tarball builds that don't have remotes?
Will we actually produce intermediate nupkgs for tarball builds? (They help with incrementality.)
If that can be ironed out, it would be pretty easy to roll out an Arcade SDK update that makes GitHubRepositoryName obsolete, then remove the property in each repo. Since it's so easy to fix incrementally later on, and it's just one line of MSBuild code, it doesn't seem like a priority.
The text was updated successfully, but these errors were encountered:
Right now,
eng/SourceBuild.props
contains<GitHubRepositoryName>source-build</GitHubRepositoryName>
. In theory, we could grab that from thegit remote
config through sourcelink.But:
Microsoft.SourceBuild.Intermediate.<something>
, so not untraceable, and not something that will break the world, but these are the stakes.If that can be ironed out, it would be pretty easy to roll out an Arcade SDK update that makes
GitHubRepositoryName
obsolete, then remove the property in each repo. Since it's so easy to fix incrementally later on, and it's just one line of MSBuild code, it doesn't seem like a priority.The text was updated successfully, but these errors were encountered: