Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DevDeviceId generation and transmission #42804

Closed
baronfel opened this issue Aug 16, 2024 · 1 comment
Closed

Implement DevDeviceId generation and transmission #42804

baronfel opened this issue Aug 16, 2024 · 1 comment
Labels
Area-Telemetry
Milestone
9.0.1xx

Comments

@baronfel
Copy link
Member

baronfel commented Aug 16, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

We should implement DevDeviceId generation, following along with the python and golang implementations. We should send this field as the property DevDeviceId and we should not hash this value. We should investigate the behavior of this implementation under sudo and non-sudo use cases to make sure that we don't crash. If we cannot generate a value, we should send the property with an empty string.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-NetSDK untriaged Request triage from a team member labels Aug 16, 2024
@baronfel baronfel added Area-Telemetry and removed untriaged Request triage from a team member Area-NetSDK labels Aug 16, 2024
@baronfel baronfel added this to the 9.0.1xx milestone Aug 16, 2024
@KalleOlaviNiemitalo
Copy link
Contributor

Go-deviceid mentions "based on the DevDeviceId specification" but is the specification public?

@marcpopMSFT marcpopMSFT mentioned this issue Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Telemetry
Projects
None yet
Milestone
9.0.1xx
Development

No branches or pull requests
3 participants
@baronfel @marcpopMSFT @KalleOlaviNiemitalo