Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SupportedOSPlatform assembly attributes are not getting generated for version less platform name #13494

Closed
buyaa-n opened this issue Sep 10, 2020 · 2 comments
Assignees
Milestone

Comments

@buyaa-n
Copy link
Contributor

buyaa-n commented Sep 10, 2020

SupportedOSPlatform assembly attributes are not getting generated for version less platform name

In dotnet/runtime#39989 (comment) we decided to rename MinimumOSPlatformAttribute into RemovedInOSPlatformAttribute and support version less platform name. We had renamed the attribute with #12775 but the version less attribute name support is missing

<PropertyGroup>
  <TargetFramework>net5.0-windows</TargetFramework>
</PropertyGroup>

Only works when adding a valid version

<PropertyGroup>
   <TargetFramework>net5.0-windows7.0</TargetFramework>
</PropertyGroup>

CC @adamsitnik @jeffhandley @terrajobst @wli3

@terrajobst terrajobst added this to the 5.0.1xx milestone Sep 10, 2020
@terrajobst
Copy link
Contributor

@marcpopMSFT the fix needs to go into RC2. Can we prioritize this?

@sfoslund
Copy link
Member

Fixed by #13507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants