Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update the CodeStyle package reference in the SDK repo #13351

Open
mavasani opened this issue Sep 3, 2020 · 2 comments
Open

Need to update the CodeStyle package reference in the SDK repo #13351

mavasani opened this issue Sep 3, 2020 · 2 comments
Assignees

Comments

@mavasani
Copy link
Contributor

mavasani commented Sep 3, 2020

@jmarolf We will need to update the CodeStyle package reference in the SDK repo once this change is merged in.

Originally posted by @mavasani in dotnet/roslyn#47297 (comment)

@jmarolf
Copy link
Contributor

jmarolf commented Sep 3, 2020

This PR was inserted into master: dotnet/roslyn#47297

master inserts into the VS Master channel which is not consumed by any SDK.

darc get-default-channels --source-repo roslyn
(1914) https://github.com/dotnet/roslyn @ features/UsedAssemblyReferences -> .NET Core Tooling Dev
(1518) https://github.com/dotnet/roslyn @ release/dev16.6-vs-deps -> .NET Core SDK 3.1.3xx
(1740) https://github.com/dotnet/roslyn @ release/dev16.6-vs-deps -> VS 16.6
(1860) https://github.com/dotnet/roslyn @ release/dev16.7-vs-deps -> VS 16.7
(1983) https://github.com/dotnet/roslyn @ master-vs-deps -> VS Master
(2032) https://github.com/dotnet/roslyn @ release/dev16.8-vs-deps -> VS 16.8

VS 16.8 is consumed into release/5.0.1xx-rc2. I am concerned about inserting analyzer assemblies that are newer than their compiler counterparts. @mavasani is it possible to port this change to the release/dev16.8 branch in roslyn?

@mavasani
Copy link
Contributor Author

mavasani commented Sep 3, 2020

@vatsalyaagrawal Is roslyn release/dev16.8 branch open for checkins? Otherwise, we can just wait for master to merge back into release/dev16.8 for 16.8 Preview4 workload before inserting the CodeStyle package into the .NET SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants