-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling first time experience in CI #12195
Comments
Same as #3828? |
@jaredpar if you add DOTNET_NOLOGO: true this disables. Now this is in .300 i added it as well and it suppresses. I think this was your goal right? Ex: https://github.com/timheuer/buildtest/runs/808185371?check_suite_focus=true#step:4:1 |
Yep that works. Thanks! Do we have this documented anywhere though in a MD file? Or is the expectation that customers should be going through GitHub issues to discover this? |
@jaredpar yep it is in the docs under environment vars section: https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet#environment-variables |
Is it intentional that
|
@PathogenDavid I think in previews we keep it for telemetry warning, is that right @marcpopMSFT -- or could just be a bug :-) |
I dug a little bit, turns out that was a red herring. Turns out the real issue there is that the ASP.NET certificate notice is part of the welcome message, so it's printed regardless of whether a certificate was actually generated. |
Got it figured it out. The It looks like #12424 will fix this for future previews. |
@PathogenDavid You are correct. We didn't have automatic code flow from 3.1 into our .net 5 branches but we have caught up with that PR and are monitoring for additional changes we'll need in the future so we should be good for a future PR. |
A customer on Twitter is mentioning that Is this a bug? |
I think that Jason is expecting it to do the same thing as It's probably unnecessarily confusing to have two different concepts use nologo, but I imagine it's way too late to switch to |
This is a separate topic, but would it make sense to have DOTNET_SKIP_FIRST_TIME_EXPERIENCE set to true by default in GitHub Actions hosted runners? Just thinking that the % of users that will know to set this is probably small, and that in aggregate worldwide having it default true could probably save some carbon emissions (and customer build minute $) :D |
would it not be somewhat logical to change things so that setting DOTNET_NOLOGO=1 would also disable the MSBuild welcome output when its run via 'dotnet msbuild' ? |
@ericsampson That's probably a better request for actions/setup-dotnet. Also IIRC Also since we're talking about carbon emissions you should probably set (Also also if you're really concerned about minutes and carbon emissions, you should probably use custom build agents that have everything you need pre-installed.)
In my opinion, it absolutely should not. What MSBuild prints is not really a welcome message. It's telling you the version of MSBuild being run, which personally is something I'd want in my CI logs. |
@PathogenDavid fair point - I guess there's no MSBUILD_NOLOGO equivalent. I don't believe that DOTNET_NOLOGO results in the nuget cache skipping. it doesn't supercede the _SKIP_FTE flag, unless I'm mistaken. FWIW, there's a bunch of .NET Core SDKs pre-installed on the Actions hosted runners - but it's really not clear to me from the setup-dotnet runner documentation if it's smart enough to use those if there's a match, or just always installs the specified SDK. |
What are the recommended steps to disable the first time experience and telemetry in CI? Specifically for GitHub Actions. I've tried using the environment variables suggested in other issues but this has no impact.
This still produces the first time output when running restore (on all OS):
The text was updated successfully, but these errors were encountered: