-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where calculation of valuetypeshapecharacteristic on Arm64 does not match native runtime #73406
Conversation
…does not match native runtime - We didn't check to make sure that the type of the Vector<T> was a primitive numeric as the runtime does - Re-enable test
b0441a5
to
fa23fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this!
runtime/src/libraries/System.Private.CoreLib/src/System/Numerics/Vector_1.cs Lines 155 to 170 in e2511ae
|
@AntonLapounov, even if the type can't do anything, a user may still end up declaring a We could theoretically throw a |
Thank you for the explanation! |
Fixes #60036