Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Obsolete ToXmlString and FromXmlString on ECC types #67246

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Obsolete ToXmlString and FromXmlString on ECC types #67246

merged 2 commits into from
Mar 28, 2022

Conversation

vcsjones
Copy link
Member

This obsoletes the ToXmlString and FromXmlString members as suggested at #50528 (comment).

Contributes to #50528.

@vcsjones vcsjones requested a review from jeffhandley as a code owner March 28, 2022 17:39
@ghost ghost assigned vcsjones Mar 28, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Mar 28, 2022

Tagging subscribers to this area: @dotnet/area-system-security, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

This obsoletes the ToXmlString and FromXmlString members as suggested at #50528 (comment).

Contributes to #50528.

Author: vcsjones
Assignees: vcsjones
Labels:

area-System.Security, new-api-needs-documentation
Milestone: -

@vcsjones vcsjones added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. and removed new-api-needs-documentation labels Mar 28, 2022
@ghost ghost added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Mar 28, 2022
@ghost
Copy link

ghost commented Mar 28, 2022 •
edited by bartonjs
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@vcsjones @bartonjs
Improve obsolete text.
25e0b31 
Co-authored-by: Jeremy Barton <[email protected]>
@bartonjs
Copy link
Member

Opened paperwork at dotnet/docs#28834

@bartonjs bartonjs removed the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Mar 28, 2022
@bartonjs bartonjs merged commit 4cfe07c into dotnet:main Mar 28, 2022
@vcsjones vcsjones deleted the obs-ecc-xml branch March 28, 2022 21:07
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bartonjs bartonjs bartonjs approved these changes

@jeffhandley jeffhandley Awaiting requested review from jeffhandley jeffhandley is a code owner

Assignees

@vcsjones vcsjones

Labels
area-System.Security breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vcsjones @bartonjs