[mono] Remove SkipVerification support from the runtime #66211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
requested review from
vargaz,
lambdageek,
SamMonoRT,
thaystg and
marek-safar
as code owners
ghost
assigned 
CAS support was removed in .NET Core. This allows us removing a bunch of code that is unused.
akoeplinger
force-pushed
the
remove-skipverification
branch
from
6a25e2a to
907fbd3
Compare
akoeplinger
commented
Mar 4, 2022
| iconv_t cd; | ||
| #endif | ||
| }; | ||
|
|
||
| static int decode_utf32be (char *inbuf, size_t inleft, gunichar *outchar); | ||
| static int encode_utf32be (gunichar c, char *outbuf, size_t outleft); |
There was a problem hiding this comment.
the decode_utf16* and decode_utf32* functions are unused too now, I didn't remove them here but let me know if you think they aren't really needed.
lambdageek
approved these changes
Mar 4, 2022
vargaz
approved these changes
Mar 5, 2022
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAS support was removed in .NET Core. This allows us removing a bunch of code that is unused, e.g. the dependency on libiconv.