Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triple slash comments for new System.Drawing API added in 6.0 #57313

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Add triple slash comments for new System.Drawing API added in 6.0 #57313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6911f54
Add triple slash comments for new System.Drawing API added in 6.0
safern Aug 12, 2021
7328536
Update src/libraries/System.Drawing.Primitives/src/System/Drawing/Col…
safern Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/Common/src/System/Drawing/KnownColor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@ public enum KnownColor
MenuHighlight,

// "Web" colors, Part 2
/// <summary>
/// A system defined color representing the ARGB value <c>#663399</c>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the existing docs, most of these seem to just be "A system-defined color.". I don't have a strong opinion, but calling out what seems like a discrepancy (if I'm looking in the right place).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that some contained the ARGB code, i.e: Purple. That's why I added it, but I don't have a strong opinion either.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this PR as is and if you have a strong opinion I can submit a new PR to fix that.

/// </summary>
RebeccaPurple,
}
}
4 changes: 4 additions & 0 deletions src/libraries/System.Drawing.Primitives/src/System/Drawing/Color.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,10 @@ namespace System.Drawing

public static Color Purple => new Color(KnownColor.Purple);

/// <summary>
/// Gets a system-defined color that has an ARGB value of <c>#663399</c>.
/// </summary>
/// <value>A system-defined color.</value>
public static Color RebeccaPurple => new Color(KnownColor.RebeccaPurple);

public static Color Red => new Color(KnownColor.Red);
Expand Down