-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add triple slash comments for new System.Drawing API added in 6.0 #57313
Conversation
Tagging subscribers to this area: @safern, @tarekgh Issue DetailsContributes to: #54865
|
@@ -197,6 +197,9 @@ public enum KnownColor | |||
MenuHighlight, | |||
|
|||
// "Web" colors, Part 2 | |||
/// <summary> | |||
/// A system defined color representing the ARGB value <c>#663399</c>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the existing docs, most of these seem to just be "A system-defined color.". I don't have a strong opinion, but calling out what seems like a discrepancy (if I'm looking in the right place).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw that some contained the ARGB code, i.e: Purple
. That's why I added it, but I don't have a strong opinion either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this PR as is and if you have a strong opinion I can submit a new PR to fix that.
src/libraries/System.Drawing.Primitives/src/System/Drawing/Color.cs
Outdated
Show resolved
Hide resolved
…or.cs Co-authored-by: Genevieve Warren <[email protected]>
Failures are unrelated. |
There is an unrelated crash here, with a dump available |
Contributes to: #54865