Properly account for padding in PUTARG_SPLIT with GT_FIELD_LIST #57279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were writing the stack part to the outgoing stack area by a loop incrementing the offset by the written size in each iteration. However, it is possible due to padding and optimization that the written size is smaller than the delta to the next field. Instead, use the offset of each field minus the offset of the first stack field to find the offset in the outgoing arg area. Fix dotnet#57064
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
No ARM32 SPMI diffs. |
jnyrup
reviewed
Aug 12, 2021
AndyAyersMS
reviewed
Aug 13, 2021
| @@ -1169,14 +1170,19 @@ void CodeGen::genPutArgSplit(GenTreePutArgSplit* treeNode) | |||
|
|
|||
| if (regIndex >= treeNode->gtNumRegs) | |||
| { | |||
| if (firstOnStackOffs == UINT_MAX) | |||
There was a problem hiding this comment.
Suggested change
| if (firstOnStackOffs == UINT_MAX) | |
| if (firstOnStackOffs == UINT_MAX) |
Co-authored-by: Andy Ayers <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were writing the stack part to the outgoing stack area by a loop
incrementing the offset by the written size in each iteration. However,
it is possible due to padding and optimization that the written size is
smaller than the delta to the next field. Instead, use the offset of
each field minus the offset of the first stack field to find the offset
in the outgoing arg area.
Fix #57064
cc @dotnet/jit-contrib