-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally capture a dump during generational aware analysis #54517
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsThis change introduces an extra option to allow generational aware analysis to capture a dump in addition to the trace files. The trace file contains information about the type of object that held the young objects alive, but very often, we also need to know the exact instance. This is particularly useful when the young objects are leaked by a delegate, where we would like to know which callback is causing the problem. @dotnet/dotnet-diag
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, @mikem8361 you want to take a look as well?
@Maoni0, can you please approve the PR if the change is good from the GC's perspective? |
looks good from GC's POV. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me : )
(And thanks for the little refactor on GenerateDump)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dump changes and EP changes look like a cleanup to me :)
This change introduces an extra option to allow generational aware analysis to capture a dump in addition to the trace files.
The trace file contains information about the type of object that held the young objects alive, but very often, we also need to know the exact instance. This is particularly useful when the young objects are leaked by a delegate, where we would like to know which callback is causing the problem.
@dotnet/dotnet-diag