Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][http] Make content stream unseekable #54303

Closed
wants to merge 2 commits into from
Closed

[wasm][http] Make content stream unseekable #54303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
499f868
Make content stream unseekable
lewing Jun 16, 2021
265e1e0
Update BrowserHttpHandler.cs
lewing Jun 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/libraries/System.Net.Http/src/System/Net/Http/BrowserHttpHandler/BrowserHttpHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ protected internal override async Task<HttpResponseMessage> SendAsync(HttpReques
requestObject.SetObjectProperty("headers", jsHeaders);
}


WasmHttpReadStream? wasmHttpReadStream = null;

JSObject abortController = new HostObject("AbortController");
Expand Down Expand Up @@ -375,6 +374,12 @@ public void Dispose()
}
}

private sealed class BrowserUnseekableStream : MemoryStream
{
public BrowserUnseekableStream (byte [] data) : base (data, writable: false) { }
public override bool CanSeek => false;
}

private sealed class BrowserHttpContent : HttpContent
{
private byte[]? _data;
Expand Down Expand Up @@ -407,7 +412,7 @@ private async Task<byte[]> GetResponseData()
protected override async Task<Stream> CreateContentReadStreamAsync()
{
byte[] data = await GetResponseData().ConfigureAwait(continueOnCapturedContext: true);
return new MemoryStream(data, writable: false);
return new BrowserUnseekableStream (data);
}

protected override Task SerializeToStreamAsync(Stream stream, TransportContext? context) =>
Expand Down