-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials fix #50230
Credentials fix #50230
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsReplaces credentials and re-password certificates.
|
src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898OneShotTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898Tests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898Tests.cs
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/Rfc2898Tests.cs
Show resolved
Hide resolved
Hello @danmoseley! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
With this change, platforms that don't support RC2 (currently only Android, bring-up still in progress) now try to use non-existent certificate files: runtime/src/libraries/Common/tests/System/Net/Configuration.Certificates.cs Lines 40 to 43 in aece157
Those files were added in dotnet/runtime-assets#120 and consumed in #49461. It looks like they were not included in dotnet/runtime-assets#124. @aik-jahoda could you get those certs included in all this credentials re-passwording / suppression work? Or point us at what needs to happen here? |
@elinor-fung there is a fix in runtime assets: dotnet/runtime-assets#128, I will change package version in runtime once the PR is merged and package published. |
- inspired by dotnet/runtime#50230
- inspired by dotnet/runtime#50230
- inspired by dotnet/runtime#50230 - cherry-picked from 1594096
- inspired by dotnet/runtime#50230 - cherry-picked from 1594096
the runtime now uses the fixed certificates: #51049 |
* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version Co-authored-by: William Godbe <[email protected]> Co-authored-by: John Luo <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: Sebastien Ros <[email protected]>
* Update branding to 2.1.27 (#3842) * Update branding to 2.1.27 * Fix patchconfig, baseline val * Update SDK and baseline * [release/2.1] Update branding to 2.1.28 (#3855) * Update branding to 2.1.28 * Bump incoming package patch versions - e.g. `$(MicrosoftNETCoreAppPackageVersion)` - updated xunit.assert and xunit.extensibility.execution minor versions - align with xunit package version * Use Ubuntu 18.04 build agents - set locale consistently on all platforms - default locale on newer agents is unloved `C.UTF-8` * !flaky fix! Double compaction timeouts * [release/2.1] Credentials fix (#3859) - inspired by dotnet/runtime#50230 - cherry-picked from 1594096 * [release/2.1] Bump some versions (#3866) * Move to latest KoreBuild / .NET SDK * Update baselines - did not ship any C# packages in 2.1.27 - re-enable baseline validation * Bump Microsoft.NETCore.App package version * Update branding to 2.1.29 (#3870) Co-authored-by: William Godbe <[email protected]> Co-authored-by: John Luo <[email protected]> Co-authored-by: Doug Bunting <[email protected]>
Replaces credentials and re-password certificates.
port of #50120