Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataContractSerialization cleanup #41824

Merged
merged 2 commits into from
Sep 4, 2020
Merged

DataContractSerialization cleanup #41824

merged 2 commits into from
Sep 4, 2020

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Sep 3, 2020

Clean up items found when doing #41476

  • Remove DiagnosticUtility.IsFatal, which always returns false.
  • Remove dead CreateDelegate method
  • Fix a TODO-NULLABLE where MemberInfo will never be null
  • Clean up remaining #if USE_REFEMIT and other unused defines in DataContractSerialization

@eerhardt
Clean up DataContractSerialization
f48de4d 
- Remove DiagnosticUtility.IsFatal, which always returns false.
- Remove dead CreateDelegate method
- Fix a TODO-NULLABLE where MemberInfo will never be null
@eerhardt
Clean up remaining #if USE_REFEMIT and other unused defines in DataCo…
8b9b40e 
…ntractSerialization
StephenMolloy
StephenMolloy approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@StephenMolloy StephenMolloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eerhardt eerhardt merged commit a196d53 into dotnet:master Sep 4, 2020
@eerhardt eerhardt deleted the DataContractSerializationCleanup branch September 4, 2020 13:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenMolloy StephenMolloy StephenMolloy approved these changes

@krwq krwq Awaiting requested review from krwq

@HongGit HongGit Awaiting requested review from HongGit

Assignees
No one assigned
Labels
area-Serialization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @StephenMolloy