Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch text param to nullable in WriteProcessingInstructionAsync #41481

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Switch text param to nullable in WriteProcessingInstructionAsync #41481

merged 1 commit into from
Aug 27, 2020

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Aug 27, 2020

In order to match with the nullability of the sync method.

@jozkee jozkee requested review from krwq, carlossanlop, eerhardt, pgovind and a team August 27, 2020 22:11
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@jozkee jozkee self-assigned this Aug 27, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

Tagging subscribers to this area: @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

@jozkee jozkee added this to the 5.0.0 milestone Aug 27, 2020
eerhardt
eerhardt approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick turnaround.

Don't forget to add this to the release/5.0 list.

@carlossanlop carlossanlop mentioned this pull request Aug 27, 2020
Merged
14 tasks
@jozkee jozkee merged commit 5348d0b into dotnet:master Aug 27, 2020
@jozkee jozkee deleted the nullability_writePIAsync branch August 27, 2020 23:54
carlossanlop pushed a commit to carlossanlop/runtime that referenced this pull request Aug 28, 2020
@jozkee @carlossanlop
Switch text param to nullable in WriteProcessingInstructionAsync (dot…
d5defc5 
…net#41481)
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffhandley jeffhandley jeffhandley approved these changes

@eerhardt eerhardt eerhardt approved these changes

@krwq krwq Awaiting requested review from krwq

@carlossanlop carlossanlop Awaiting requested review from carlossanlop

@pgovind pgovind Awaiting requested review from pgovind

Assignees

@jozkee jozkee

Labels
area-System.Xml
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jozkee @Dotnet-GitSync-Bot @jeffhandley @eerhardt