Port nullability annotations to refs XmlDocument and XmlSerializer #41474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jeffhandley
approved these changes
Aug 28, 2020
krwq
reviewed
Aug 28, 2020
src/libraries/System.Data.Common/src/System/Data/Common/ObjectStorage.cs
Show resolved
Hide resolved
krwq
reviewed
Aug 28, 2020
| @@ -161,7 +161,7 @@ public override object ConvertXmlToObject(string s) | |||
|
|
|||
| StringReader strreader = new StringReader(s); | |||
| XmlSerializer deserializerWithOutRootAttribute = ObjectStorage.GetXmlSerializer(_dataType); | |||
| return (deserializerWithOutRootAttribute.Deserialize(strreader)); | |||
| return (deserializerWithOutRootAttribute.Deserialize(strreader))!; | |||
There was a problem hiding this comment.
also IMO we should file an issue to investigate if this should return nullable here and below
krwq
reviewed
Aug 28, 2020
src/libraries/System.Xml.XmlSerializer/ref/System.Xml.XmlSerializer.cs
Outdated
Show resolved
Hide resolved
krwq
approved these changes
Aug 28, 2020
|
LGTM, please file an issue for the potential System.Data.Common issue (or TODO-NULLABLE) |
|
Hello @jozkee! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
carlossanlop
pushed a commit
to carlossanlop/runtime
that referenced
this pull request
Aug 28, 2020
…otnet#41474) * Port nullability annotations to refs XmlDocument and XmlSerializer * Fix new System.Data.Common nullability related errors * Switch nullability of parameter in SoapElementAttribute ctor
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2339
For System.Xml.XmlDocument all types were forwarded to ReaderWriter assembly so I only enabled nullability in the csprojs.
For System.Xml.XmlSerializer some types were forwarded to ReaderWriter but some other types were in place.