Globally enable nullability in XML #41438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jozkee
reviewed
Aug 27, 2020
| @@ -1,5 +1,6 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
Is it correct to disable nullability on files inside of the Common folder?
There was a problem hiding this comment.
I did it for now because other projects depend on it and enabling is causing errors which I do not want to fix as part of this PR. I'll open the issue on this
14 tasks
jozkee
reviewed
Aug 27, 2020
| @@ -1,6 +1,7 @@ | |||
| // Licensed to the .NET Foundation under one or more agreements. | |||
| // The .NET Foundation licenses this file to you under the MIT license. | |||
|
|
|||
| #nullable disable | |||
There was a problem hiding this comment.
XSLT runtime is only used by generated code and won't help customers as none of these APIs is meant for consumption so not worth annotating (in long term perhaps to find some NREs but we got limited time now so this part was cut)
carlossanlop
pushed a commit
to carlossanlop/runtime
that referenced
this pull request
Aug 28, 2020
* Globally enable nullability in XML * remove double #nullable enable in the file
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#nullable enable)