WASM: Add SHA* hash functions #40486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
requested review from
alexischr,
CoffeeFlux,
lambdageek,
thaystg and
vargaz
as code owners
EgorBo
reviewed
Aug 6, 2020
vcsjones
reviewed
Aug 6, 2020
src/libraries/System.Security.Cryptography.Algorithms/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Algorithms/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
|
Seeing as you added me I question the need for any of this. Is there a driving customer requirement for parity in WASM? |
GrabYourPitchforks
added
the
NO-MERGE
|
Marking this no merge for now while we work through compliance-related details. |
Yes, this is needed |
vargaz
reviewed
Aug 27, 2020
GrabYourPitchforks
removed
the
NO-MERGE
|
Unmarking no merge per email thread from this morning. But please make the requested changes at your convenience. :) |
This ports the managed SHA* hash functions from https://github.com/microsoft/referencesource so we can use them on Browser/WASM where we don't have OpenSSL. Enables the System.Security.Cryptography.Algorithms tests for these classes: `Tests run: 271, Errors: 0, Failures: 0, Skipped: 1. Time: 11.028473s` Resolves dotnet#40076
akoeplinger
force-pushed
the
wasm-hash-functions
branch
from
3f0d0ca to
c28de45
Compare
akoeplinger
changed the title
|
Updated the PR:
|
GrabYourPitchforks
approved these changes
Sep 2, 2020
|
/backport to release/5.0-rc2 |
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/236751870 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the managed SHA* hash functions from https://github.com/microsoft/referencesource so we can use them on Browser/WASM where we don't have OpenSSL.
Enables the System.Security.Cryptography.Algorithms tests for these classes:
Tests run: 271, Errors: 0, Failures: 0, Skipped: 1. Time: 11.857137sResolves #40076
(related: implement this using the web crypto APIs in .NET6: #40074)