Fix 'varDsc->lvExactSize == 12' assert. #38484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dotnet-GitSync-Bot
added
the
area-CodeGen-coreclr
sandreenko
force-pushed
the
fixSIMD12Assert
branch
from
5b593cb to
338a4d1
Compare
sandreenko
force-pushed
the
fixSIMD12Assert
branch
from
16f31a2 to
6294a31
Compare
|
PTAL @briansull @CarolEidt @tannergooding @dotnet/jit-contrib |
briansull
reviewed
Jul 1, 2020
| { | ||
| m_pCompiler->lvaGetDesc(cseLclVarNum)->lvSIMDType = true; |
There was a problem hiding this comment.
Do we still set lvSIMDType to true for the new CSE SIMD LclVars?
Is it done by lvaSetStruct?
There was a problem hiding this comment.
Yes,lvaSetStruct handles it:
runtime/src/coreclr/src/jit/lclvars.cpp
Lines 2633 to 2637 in d69cfa0
src/coreclr/src/jit/optcse.cpp
Outdated
| @@ -3216,7 +3214,7 @@ bool Compiler::optIsCSEcandidate(GenTree* tree) | |||
|
|
|||
| // If this is a struct type, we can only consider it for CSE-ing if we can get at | |||
| // its handle, so that we can create a temp. | |||
There was a problem hiding this comment.
// If this is a struct type (or SIMD type),
|
👍 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a small pessimization, but no diffs(benchmarks/libraries),
I had a more ambitious change (based on Tanner's suggestion and ClassLayout added to JitIntrinsic by Carol recently) that required layout for each Intrinsic (SIMD and HW) node to be initialized and it was passing tests. However:
LCL_FLDfor structs with overlapping fields when we dropFldSeqand can't restoreCLASS_HANDLEafter, so it was not clear for me how to keep struct handle in this case.Fixes #36586.