Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Disable System.Security.Cryptography.* tests. #37723

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

steveisok
Copy link
Member

Since we aren't shipping openssl and browser crypto interop requires sync over async, we need to disable the tests until a viable solution is found.

Since we aren't shipping openssl and browser crypto interop requires sync over async, we need to disable the tests until a viable solution is found.
@ghost
Copy link

ghost commented Jun 10, 2020

Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq
Notify danmosemsft if you want to be subscribed.

@steveisok steveisok added the arch-wasm WebAssembly architecture label Jun 10, 2020
@steveisok steveisok requested review from akoeplinger and a team June 10, 2020 22:41
@steveisok
Copy link
Member Author

Failures aren't related

@steveisok steveisok merged commit 8484d6c into dotnet:master Jun 11, 2020
@steveisok steveisok deleted the disable-crypto-tests branch June 11, 2020 11:59
akoeplinger pushed a commit that referenced this pull request Jun 29, 2020
Since the entire set of System.Security.Cryptography.* tests has been disabled on WASM recently in #37723, we need to let everyone know that those areas are not quite supported on WASM at the moment. In that case System.Security.Cryptography classes could throw PlatformNotSupportedException until some solution comes (#37669)
kevinwkt pushed a commit to kevinwkt/runtimelab that referenced this pull request Jul 15, 2020
Since the entire set of System.Security.Cryptography.* tests has been disabled on WASM recently in dotnet/runtime#37723, we need to let everyone know that those areas are not quite supported on WASM at the moment. In that case System.Security.Cryptography classes could throw PlatformNotSupportedException until some solution comes (dotnet/runtime#37669)
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants