-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MonoAotCompiler msbuild task #35961
Conversation
Tagging subscribers to this area: @ViktorHofer |
Tagging subscribers to this area: @directhex |
@@ -203,4 +178,57 @@ public override bool Execute() | |||
|
|||
return true; | |||
} | |||
|
|||
static void GenerateLinkAllFile(IEnumerable<string> asmFiles, string outputFile) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the AOTCompilation task won't be responsible for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: explicit access modifier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm good question, it sounds pretty iOS specific to me so I don't think it makes sense in the shared AOT task.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's FullAOT-specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's specifically because of the --aot=static
option that iOS is using and from what I can see XA doesn't right now.
We'd have to make it generic enough to be useful (e.g. deal with the TARGET_OS_IPHONE
defines, <TargetConditionals.h>
includes, .m vs. .c etc.) so I'd leave it separate for now.
8444dff
to
8d07aa1
Compare
Imho, the app build task should use the aot compiler task internally, it shouldn't be exposed to the user, it's an internal component. |
@vargaz that doesn't work, the AOT task will live in dotnet/sdk eventually and be used by the |
This will eventually be upstreamed to dotnet/sdk.