Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MonoAotCompiler msbuild task #35961

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented May 7, 2020

This will eventually be upstreamed to dotnet/sdk.

@ghost
Copy link

ghost commented May 7, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@ghost
Copy link

ghost commented May 7, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

@@ -203,4 +178,57 @@ public override bool Execute()

return true;
}

static void GenerateLinkAllFile(IEnumerable<string> asmFiles, string outputFile)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the AOTCompilation task won't be responsible for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: explicit access modifier

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm good question, it sounds pretty iOS specific to me so I don't think it makes sense in the shared AOT task.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's FullAOT-specific

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's specifically because of the --aot=static option that iOS is using and from what I can see XA doesn't right now.

We'd have to make it generic enough to be useful (e.g. deal with the TARGET_OS_IPHONE defines, <TargetConditionals.h> includes, .m vs. .c etc.) so I'd leave it separate for now.

@akoeplinger akoeplinger force-pushed the aot-task branch 2 times, most recently from 8444dff to 8d07aa1 Compare May 12, 2020 15:47
@akoeplinger akoeplinger marked this pull request as ready for review May 12, 2020 17:11
@akoeplinger akoeplinger requested a review from vargaz as a code owner May 12, 2020 17:11
@vargaz
Copy link
Contributor

vargaz commented May 12, 2020

Imho, the app build task should use the aot compiler task internally, it shouldn't be exposed to the user, it's an internal component.

@akoeplinger
Copy link
Member Author

@vargaz that doesn't work, the AOT task will live in dotnet/sdk eventually and be used by the dotnet publish pipeline.

@akoeplinger akoeplinger merged commit cb3c4b1 into dotnet:master May 13, 2020
@akoeplinger akoeplinger deleted the aot-task branch May 14, 2020 07:55
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants