Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a regression in gc_heap::get_current_allocated #35744

Merged
merged 1 commit into from
May 4, 2020

Conversation

Maoni0
Copy link
Member

@Maoni0 Maoni0 commented May 2, 2020

introduced by
Refactor handling of non-SOH generations #1688

this is supposed to get the user allocations, originally it was getting gen0 and gen3. with the refactor it should get gen0 and all UOH allocations.

unfortunately I didn't notice this when I did the CR.

Refactor handling of non-SOH generations (dotnet#1688)
@ghost
Copy link

ghost commented May 2, 2020

Tagging subscribers to this area: @Maoni0
Notify danmosemsft if you want to be subscribed.

@Maoni0
Copy link
Member Author

Maoni0 commented May 2, 2020

@cshung PTAL

@cshung cshung self-requested a review May 4, 2020 17:25
Copy link
Member

@cshung cshung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maoni0 Maoni0 merged commit 2b3de4f into dotnet:master May 4, 2020
@Maoni0 Maoni0 deleted the refactor_fix branch June 15, 2020 01:26
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants