Allow allocating large object from free list while background sweeping SOH #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Maoni0 is added to the review. #Closed |
|
hmm, too bad the lines didn't actually get displayed (just the line #) but if you open this in codeflow it should work |
cshung
changed the title
VSadov
added a commit
to VSadov/runtime
that referenced
this pull request
Jan 29, 2020
VSadov
added a commit
that referenced
this pull request
Jan 29, 2020
* refactoring * ploh-->uoh * fix Linux build PR feedback * some PR feedback * more PR feedback more PR feedback * more PR feedback * address comments in UpdatePreGCCounters * removed a confusing comment * stress fix in background sweep * use `saved_sweep_ephemeral_seg` in background sweep. * fixed `GCPerHeapHistory_V3` event. * re-implemented #2103 on top of refactoring (it was hard to merge)
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Mar 28, 2020
* refactoring * ploh-->uoh * fix Linux build PR feedback * some PR feedback * more PR feedback more PR feedback * more PR feedback * address comments in UpdatePreGCCounters * removed a confusing comment * stress fix in background sweep * use `saved_sweep_ephemeral_seg` in background sweep. * fixed `GCPerHeapHistory_V3` event. * re-implemented dotnet/runtime#2103 on top of refactoring (it was hard to merge)
MichalStrehovsky
pushed a commit
to MichalStrehovsky/corert
that referenced
this pull request
Mar 31, 2020
* refactoring * ploh-->uoh * fix Linux build PR feedback * some PR feedback * more PR feedback more PR feedback * more PR feedback * address comments in UpdatePreGCCounters * removed a confusing comment * stress fix in background sweep * use `saved_sweep_ephemeral_seg` in background sweep. * fixed `GCPerHeapHistory_V3` event. * re-implemented dotnet/runtime#2103 on top of refactoring (it was hard to merge)
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Apr 1, 2020
* refactoring * ploh-->uoh * fix Linux build PR feedback * some PR feedback * more PR feedback more PR feedback * more PR feedback * address comments in UpdatePreGCCounters * removed a confusing comment * stress fix in background sweep * use `saved_sweep_ephemeral_seg` in background sweep. * fixed `GCPerHeapHistory_V3` event. * re-implemented dotnet/runtime#2103 on top of refactoring (it was hard to merge)
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1848
The change postponed the clearing of the free lists of the large object heap, that allows the free list to be used while the background small object heap sweeping is in progress.
Stress tests involving large object allocation mixed with all the existing test cases survived the stress run over the weekend without crashing or deadlock.