-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create "crossgen pack" for new crossgen2 compiler #906
Comments
Finally working on this starting today, my dotnet/runtime official build infra and build uptake backlog is out of critical issues for now. 😄 |
cc @dotnet/crossgen-contrib FYI |
Quick update. Got sidetracked by issues related to this month's release but starting to iterate on changes now. Context: The CoreCLR build zips up its artifacts to give to the Installer part of the build, where these packs are made. (Two separate machines in the official build.) This includes the crossgen2 directory with ~230 files (not just the 10 that are packaged up in the current What I'm planning to do to keep things simple is move the runtimeconfig generation code and the 10 file selection code to Installer. The I can also go ahead and package up all the files in the |
The long term plan is that we'll eventually ship crossgen2 as a self-contained app package, because this will be especially useful for any cross-platform/cross-architecture compilation. |
At the moment it looks like crossgen2 is being built on Made pretty good progress on this yesterday, I have dotnet/arcade#4650 open on the Arcade side to add support once merged, and #1859 to uptake. (An Arcade SDK update will need to be merged before it can clear CI.) It's looking like a few days until this gets produced by an official build. |
No. I think the bug is that I probably forgot to create a package for linux-musl-x64 :) |
Ah, well no worries then, what I've done so far is already set up to produce it. 😄 |
To update this thread: the packs will now be "crossgen2 packs", |
This was completed by #1859 Jan 17, I missed closing this issue. A few tracking issues for cleanup:
|
PR dotnet/coreclr#27296 creates
Microsoft.NETCore.Crossgen2
transport packages for the new crossgen compiler. These need to be shipped as new packs similar to apphost and runtime packs so the SDK can resolve and download the new crossgen for use in builds.Microsoft.NETCore.App.Crossgen.<RID>
is what I'm thinking for the new pack ID. There's some uncertainty about the name of the tool: dotnet/coreclr#27296 (comment). TheCrossgen
part may need tweaking.When the old crossgen is eventually phased out, it will be removed from the runtime pack.
crossgen2
won't takecrossgen
's place in the runtime pack. It isn't considered good that crossgen was in the runtime pack to begin with, so this is an opportunity to fix that.This new pack should have the same set of installers/packages as runtime packs.
The transport package isn't built for the full set of NETCoreApp RIDs yet, so we'll match that in Core-Setup for now.
/cc @fadimounir @nguerrera @dleeapho @MichaelSimons
The text was updated successfully, but these errors were encountered: