Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite 3 MemoryCache tests to not be timing sensitive #72890

Open
danmoseley opened this issue Jul 26, 2022 · 1 comment
Open

Rewrite 3 MemoryCache tests to not be timing sensitive #72890

danmoseley opened this issue Jul 26, 2022 · 1 comment
Labels
area-Extensions-Caching disabled-test The test is disabled in source code against the issue help wanted [up-for-grabs] Good issue for external contributors
Milestone
Future

Comments

@danmoseley
Copy link
Member

GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues
OvercapacityPurge_AreThreadSafe
AddAndReplaceEntries_AreThreadSafe

These were inherited from aspnet/caching but have been disabled as they need rewriting to not be racy.

example failure

System.AggregateException : One or more errors occurred.
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.


Stack trace
   at System.Threading.Tasks.Task.WaitAll(Task[] tasks, Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Microsoft.Extensions.Caching.Memory.MemoryCacheSetAndRemoveTests.OvercapacityPurge_AreThreadSafe() in /_/src/libraries/Microsoft.Extensions.Caching.Memory/tests/MemoryCacheSetAndRemoveTests.cs:line 655
----- Inner Stack Trace -----
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 26, 2022
@ghost
Copy link

ghost commented Jul 26, 2022

Tagging subscribers to this area: @dotnet/area-extensions-caching
See info in area-owners.md if you want to be subscribed.

Issue Details

GetAndSet_AreThreadSafe_AndUpdatesNeverLeavesNullValues
OvercapacityPurge_AreThreadSafe
AddAndReplaceEntries_AreThreadSafe

These were inherited from aspnet/caching but have been disabled as they need rewriting to not be racy.

example failure

System.AggregateException : One or more errors occurred.
---- System.Threading.Tasks.TaskCanceledException : A task was canceled.


Stack trace
   at System.Threading.Tasks.Task.WaitAll(Task[] tasks, Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at Microsoft.Extensions.Caching.Memory.MemoryCacheSetAndRemoveTests.OvercapacityPurge_AreThreadSafe() in /_/src/libraries/Microsoft.Extensions.Caching.Memory/tests/MemoryCacheSetAndRemoveTests.cs:line 655
----- Inner Stack Trace -----
Author: danmoseley
Assignees: -
Labels:

area-Extensions-Caching
Milestone: -

@danmoseley danmoseley mentioned this issue Jul 26, 2022
Merged
@eerhardt eerhardt added the disabled-test The test is disabled in source code against the issue label Aug 1, 2022
@eerhardt eerhardt added this to the Future milestone Aug 1, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 1, 2022
@adamsitnik adamsitnik added the help wanted [up-for-grabs] Good issue for external contributors label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Extensions-Caching disabled-test The test is disabled in source code against the issue help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@adamsitnik @danmoseley @eerhardt