Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.NETCore.App.Composite packaging misauthored - currently only win-x64 packages get published #72828

Closed
hoyosjs opened this issue Jul 26, 2022 · 8 comments · Fixed by #89946
Assignees
Milestone

Comments

@hoyosjs
Copy link
Member

hoyosjs commented Jul 26, 2022

The Microsoft.NETCore.App Composite package appears to be named in a rid-agnostic way on NuGet.org, but has RID specific binaries.

Originally posted by @mmitche in #72701 (comment)

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 26, 2022
@hoyosjs hoyosjs added area-crossgen2-coreclr untriaged New issue has not been triaged by the area owner and removed untriaged New issue has not been triaged by the area owner labels Jul 26, 2022
@mmitche
Copy link
Member

mmitche commented Jul 26, 2022

This might be a situation where we should put some checks in place to avoid this mistake in the future?

/cc @ericstj This is pretty close to what we were talking about last week. This is a partial package that is being published under a rid-agnostic name.

@ericstj
Copy link
Member

ericstj commented Jul 26, 2022

Perhaps, I have no idea what this package is for so I can't say for certain.

@mangod9 mangod9 removed the untriaged New issue has not been triaged by the area owner label Jul 30, 2022
@mangod9 mangod9 added this to the 8.0.0 milestone Jul 30, 2022
@mangod9
Copy link
Member

mangod9 commented Jul 30, 2022

Since the composite packages are still experimental and not consumed downstream yet, moving this to 8, unless its blocking any builds. fyi @davidwrighton

@mmitche
Copy link
Member

mmitche commented Aug 1, 2022

@mangod9 They're shipping to customers on nuget.org though? Should that be removed for now?

@mangod9
Copy link
Member

mangod9 commented Aug 1, 2022

They're shipping to customers on nuget.org though?

I am not aware of anyone consuming these so should be ok to remove. @davidwrighton to confirm.

@mmitche
Copy link
Member

mmitche commented Aug 1, 2022

Okay. We should mark these packages as non-shipping then, too, if we're not going to fix the authoring error.

@trylek trylek mentioned this issue May 3, 2023
46 tasks
@mangod9
Copy link
Member

mangod9 commented Jun 23, 2023

this packages is actually not being used. Perhaps we should remove from building in the runtime repo?

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 3, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants