Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interop ComWrappersTests failures #62063

Closed
am11 opened this issue Nov 25, 2021 · 1 comment · Fixed by #62066
Closed

Interop ComWrappersTests failures #62063

am11 opened this issue Nov 25, 2021 · 1 comment · Fixed by #62066
Labels
area-Interop-coreclr untriaged New issue has not been triaged by the area owner

Comments

@am11
Copy link
Member

am11 commented Nov 25, 2021

Noticed in pri1 run on helix - https://helix.dot.net/api/2019-06-17/jobs/4389830b-bb7a-4316-8d83-fd59f0b90036/workitems/Interop/console

  Discovered:  Interop.COM.XUnitWrapper (found 25 test cases)
  Starting:    Interop.COM.XUnitWrapper (parallel test collections = on, max threads = 8)
    Interop\COM\ComWrappers\API\ComWrappersTests\ComWrappersTests.cmd [FAIL]
      
      Assert failure(PID 15768 [0x00003d98], Thread: 14976 [0x3a80]): pThread
      
      CORECLR! InteropLibImports::HasValidTarget + 0x4C (0x00007ffc`666457f4)
      CORECLR! TrackerTarget_QueryInterface + 0x9C (0x00007ffc`66848a8c)
      MOCKREFERENCETRACKERRUNTIME! UpdateTestObjectAsIDispatch + 0x1F5B8 (0x00007ffc`64d7b1b8)
      MOCKREFERENCETRACKERRUNTIME! UpdateTestObjectAsIDispatch + 0x1EA80 (0x00007ffc`64d7a680)
      CORECLR! TrackerObjectManager::BeginReferenceTracking + 0xEC (0x00007ffc`6684a42c)
      CORECLR! InteropLib::Com::BeginExternalObjectReferenceTracking + 0x14 (0x00007ffc`668481c4)
      CORECLR! ComWrappersNative::OnFullGCStarted + 0xF8 (0x00007ffc`66645c98)
      CORECLR! standalone::GCToEEInterface::GcStartWork + 0x28 (0x00007ffc`66641ed8)
      CLRGC! SVR::gc_heap::garbage_collect + 0x584 (0x00007ffc`6ebb286c)
      CLRGC! SVR::gc_heap::gc_thread_function + 0x2E8 (0x00007ffc`6ebb5220)
          File: D:\a\_work\1\s\src\coreclr\vm\threads.inl Line: 43
          Image: D:\h\w\AF030992\p\corerun.exe
      
      
      Return code:      1
      Raw output file:      D:\h\w\AF030992\w\A107096A\uploads\Reports\Interop.COM\ComWrappers\API\ComWrappersTests\ComWrappersTests.output.txt
      Raw output:
      BEGIN EXECUTION
       "D:\h\w\AF030992\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  ComWrappersTests.dll 
      Running ValidateComInterfaceCreation...
      Running ValidateComInterfaceCreationRoundTrip...
      Running ValidateFallbackQueryInterface...
      Running ValidateCreateObjectCachingScenario...
      Running ValidateWrappersInstanceIsolation...
      Running ValidatePrecreatedExternalWrapper...
      Running ValidateExternalWrapperCacheCleanUp...
      Running ValidateSuppliedInnerNotAggregation...
      Running ValidateIUnknownImpls...
      Running ValidateBadComWrapperImpl...
      Running ValidateRuntimeTrackerScenario...
      Expected: 100
      Actual: -1073740286
      END EXECUTION - FAILED
      FAILED
      Test Harness Exitcode is : 1
      To run the test:
      > set CORE_ROOT=D:\h\w\AF030992\p
      > D:\h\w\AF030992\w\A107096A\e\Interop\COM\ComWrappers\API\ComWrappersTests\ComWrappersTests.cmd
      Expected: True
      Actual:   False
      Stack Trace:
           at Interop_COM._ComWrappers_API_ComWrappersTests_ComWrappersTests_._ComWrappers_API_ComWrappersTests_ComWrappersTests_cmd()
      Output:
        
        Assert failure(PID 15768 [0x00003d98], Thread: 14976 [0x3a80]): pThread
        
        CORECLR! InteropLibImports::HasValidTarget + 0x4C (0x00007ffc`666457f4)
        CORECLR! TrackerTarget_QueryInterface + 0x9C (0x00007ffc`66848a8c)
        MOCKREFERENCETRACKERRUNTIME! UpdateTestObjectAsIDispatch + 0x1F5B8 (0x00007ffc`64d7b1b8)
        MOCKREFERENCETRACKERRUNTIME! UpdateTestObjectAsIDispatch + 0x1EA80 (0x00007ffc`64d7a680)
        CORECLR! TrackerObjectManager::BeginReferenceTracking + 0xEC (0x00007ffc`6684a42c)
        CORECLR! InteropLib::Com::BeginExternalObjectReferenceTracking + 0x14 (0x00007ffc`668481c4)
        CORECLR! ComWrappersNative::OnFullGCStarted + 0xF8 (0x00007ffc`66645c98)
        CORECLR! standalone::GCToEEInterface::GcStartWork + 0x28 (0x00007ffc`66641ed8)
        CLRGC! SVR::gc_heap::garbage_collect + 0x584 (0x00007ffc`6ebb286c)
        CLRGC! SVR::gc_heap::gc_thread_function + 0x2E8 (0x00007ffc`6ebb5220)
            File: D:\a\_work\1\s\src\coreclr\vm\threads.inl Line: 43
            Image: D:\h\w\AF030992\p\corerun.exe
        
        
        Return code:      1
        Raw output file:      D:\h\w\AF030992\w\A107096A\uploads\Reports\Interop.COM\ComWrappers\API\ComWrappersTests\ComWrappersTests.output.txt
        Raw output:
        BEGIN EXECUTION
         "D:\h\w\AF030992\p\corerun.exe" -p "System.Reflection.Metadata.MetadataUpdater.IsSupported=false"  ComWrappersTests.dll 
        Running ValidateComInterfaceCreation...
        Running ValidateComInterfaceCreationRoundTrip...
        Running ValidateFallbackQueryInterface...
        Running ValidateCreateObjectCachingScenario...
        Running ValidateWrappersInstanceIsolation...
        Running ValidatePrecreatedExternalWrapper...
        Running ValidateExternalWrapperCacheCleanUp...
        Running ValidateSuppliedInnerNotAggregation...
        Running ValidateIUnknownImpls...
        Running ValidateBadComWrapperImpl...
        Running ValidateRuntimeTrackerScenario...
        Expected: 100
        Actual: -1073740286
        END EXECUTION - FAILED
        FAILED
        Test Harness Exitcode is : 1
        To run the test:
        > set CORE_ROOT=D:\h\w\AF030992\p
        > D:\h\w\AF030992\w\A107096A\e\Interop\COM\ComWrappers\API\ComWrappersTests\ComWrappersTests.cmd
    Interop\COM\ComWrappers\API\ComWrappersTestsBuiltInComDisabled\ComWrappersTestsBuiltInComDisabled.cmd [FAIL]
      
      Assert failure(PID 11576 [0x00002d38], Thread: 16036 [0x3ea4]): pThread
      
      CORECLR! InteropLibImports::HasValidTarget + 0x4C (0x00007ffc`666457f4)
      CORECLR! TrackerTarget_QueryInterface + 0x9C (0x00007ffc`66848a8c)
      MOCKREFERENCETRACKERRUNTIME! UpdateTestObjectAsIDispatch + 0x1F5B8 (0x00007ffc`6b4bb1b8)
      MOCKREFERENCETRACKERRUNTIME! UpdateTestObjectAsIDispatch + 0x1EA80 (0x00007ffc`6b4ba680)
      CORECLR! TrackerObjectManager::BeginReferenceTracking + 0xEC (0x00007ffc`6684a42c)
      CORECLR! InteropLib::Com::BeginExternalObjectReferenceTracking + 0x14 (0x00007ffc`668481c4)
      CORECLR! ComWrappersNative::OnFullGCStarted + 0xF8 (0x00007ffc`66645c98)
      CORECLR! standalone::GCToEEInterface::GcStartWork + 0x28 (0x00007ffc`66641ed8)
      CLRGC! SVR::gc_heap::garbage_collect + 0x584 (0x00007ffc`6ebb286c)
      CLRGC! SVR::gc_heap::gc_thread_function + 0x2E8 (0x00007ffc`6ebb5220)
          File: D:\a\_work\1\s\src\coreclr\vm\threads.inl Line: 43
          Image: D:\h\w\AF030992\p\corerun.exe
      
      
      Return code:      1
@dotnet-issue-labeler dotnet-issue-labeler bot added area-Interop-coreclr untriaged New issue has not been triaged by the area owner labels Nov 25, 2021
@jkotas
Copy link
Member

jkotas commented Nov 25, 2021 •
edited
Loading

Potential fix: GC handle can be checked for NULL using ObjectHandleIsNull without switching the GC modes.

@am11 am11 mentioned this issue Nov 26, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 26, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-Interop-coreclr untriaged New issue has not been triaged by the area owner
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid switching GC mode in COM's HasValidTarget am11/runtime
2 participants
@am11 @jkotas