Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC: we should figure out how to properly handle international names in Quic/Http3 #55687

Closed
wfurt opened this issue Jul 14, 2021 · 3 comments · Fixed by #84976
Closed

QUIC: we should figure out how to properly handle international names in Quic/Http3 #55687

wfurt opened this issue Jul 14, 2021 · 3 comments · Fixed by #84976
Labels
area-System.Net.Quic bug help wanted [up-for-grabs] Good issue for external contributors
Milestone

Comments

@wfurt
Copy link
Member

wfurt commented Jul 14, 2021

This was raised as part #55468.
For international names, we should make sure they are properly set for outbound connections.
On Listener, we may need to pass the name certificate selection callback.

We should make sure that in both cases we match SslStream.
It is unclear at this point what MsQuic expects and if it does any normalization. e.g. punycode of if this is expected from caller.

cc: @nibanks

@ghost
Copy link

ghost commented Jul 14, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This was raised as part #55468.
For international names, we should make sure they are properly set for outbound connections.
On Listener, we may need to pass the name certificate selection callback.

We should make sure that in both cases we match SslStream.
It is unclear at this point what MsQuic expects and if it does any normalization. e.g. punycode of if this is expected from caller.

cc: @nibanks

Author: wfurt
Assignees: -
Labels:

area-System.Net.Quic

Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 14, 2021
@nibanks
Copy link

nibanks commented Jul 14, 2021

The SNI is treated practically as a binary blob by MsQuic, directly from the TLS payload. So it could be anything from the peer.

@ManickaP ManickaP added this to the 6.0.0 milestone Jul 15, 2021
@ManickaP ManickaP removed the untriaged New issue has not been triaged by the area owner label Jul 15, 2021
@ManickaP ManickaP modified the milestones: 6.0.0, 7.0.0 Jul 15, 2021
@ManickaP
Copy link
Member

Triage: we need to unicode the data. Unicode names are not that wide-spread, punting to 7.0

@karelz karelz added bug help wanted [up-for-grabs] Good issue for external contributors labels Nov 16, 2021
@karelz karelz modified the milestones: 7.0.0, Future Jun 14, 2022
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 20, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 25, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
@karelz karelz modified the milestones: Future, 8.0.0 May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Quic bug help wanted [up-for-grabs] Good issue for external contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants