Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize DispatchProxyGenerator code path by using MetdataToken #53285

Closed
ViktorHofer opened this issue May 26, 2021 · 1 comment · Fixed by #55801
Closed

Optimize DispatchProxyGenerator code path by using MetdataToken #53285

ViktorHofer opened this issue May 26, 2021 · 1 comment · Fixed by #55801
Labels
area-System.Reflection enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Milestone
Future

Comments

@ViktorHofer
Copy link
Member

See comment:

runtime/src/libraries/System.Reflection.DispatchProxy/src/System/Reflection/DispatchProxyGenerator.cs

Lines 834 to 836 in e8875e3

// This assembly should work in netstandard1.3,
// so we cannot use MemberInfo.MetadataToken here.
// Therefore, it compares honestly referring ECMA-335 I.8.6.1.6 Signature Matching.

With #53283, we won't build a netstandard1.x configuration of this library anymore and the code path can be optimized. FWIW this could have already be done in the past via ifdef compiler directives.

cc @buyaa-n @joperezr @krwq @steveharter @jeffhandley
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label May 26, 2021
@ViktorHofer ViktorHofer mentioned this issue May 26, 2021
Merged
@buyaa-n buyaa-n added this to the 6.0.0 milestone May 27, 2021
@buyaa-n buyaa-n removed the untriaged New issue has not been triaged by the area owner label May 27, 2021
@krwq krwq added enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors labels Jul 15, 2021
@krwq krwq modified the milestones: 6.0.0, Future Jul 15, 2021
@FatTigerWang
Copy link
Contributor

@ViktorHofer I will use MethodInfo.MetadataTokenn and MethodInfo.Module.Name to judge

@ghost ghost added the needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration label Jul 16, 2021
@FatTigerWang FatTigerWang mentioned this issue Jul 16, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jul 16, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jul 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-System.Reflection enhancement Product code improvement that does NOT require public API changes/additions help wanted [up-for-grabs] Good issue for external contributors needs-further-triage Issue has been initially triaged, but needs deeper consideration or reconsideration
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
Future
Development

Successfully merging a pull request may close this issue.

#53285 switch to use MemberInfo.MetadataToken
4 participants
@krwq @ViktorHofer @FatTigerWang @buyaa-n