-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Estimate ICU data size savings when only shipping English #48355
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsIt should be possible to modify https://github.com/dotnet/icu/tree/maint/maint-67/icu-filters and generate the data file for only English instead of EFIGS to see how much space we save. To generate the file, you need to build the full repo, and then you can rebuild the data files after adjusting the filter with @tannergooding can you handle getting the estimate?
|
If the size savings looks worthwhile, we can adjust this issue to split up the files further. |
Full EFIGS:
This is uncompressed. I'm not sure this is significant enough of a win post-compression to justify the extra effort, but cc: @eerhardt |
Also, for reference, all English locales:
|
Compressed sizes? |
That one is harder to check without knowing the exact Brotli settings we use - do you know where I can find those? |
By default, we use quality 11. Full EFIGS:
All English locales:
en_US only:
So shipping only en_US instead of EFIGS saves about 18k. All English locales is around 10k. |
@lewing do you think this is worth splitting up further, or is the savings here not worth the added complexity? I'd prefer to defer that judgement to you since I don't have a good idea of the complexity this would add on the Blazor end, but I would assume it's not really worth it. |
This is probably only worth it if we are able to split the locale-specific data from the more generic data required. |
It should be possible to modify https://github.com/dotnet/icu/tree/maint/maint-67/icu-filters and generate the data file for only English instead of EFIGS to see how much space we save.
To generate the file, you need to build the full repo, and then you can rebuild the data files after adjusting the filter with
make -f icu.mk data-icudt TARGET_OS=browser TARGET_ARCHITECTURE=wasm
.The text was updated successfully, but these errors were encountered: