Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bundling unnecessary functionality in the wasm published output #48225

Closed
2 of 3 tasks
CoffeeFlux opened this issue Feb 12, 2021 · 7 comments
Closed
2 of 3 tasks
Assignees
Labels
arch-wasm WebAssembly architecture area-Build-mono size-reduction Issues impacting final app size primary for size sensitive workloads tracking This issue is tracking the completion of other related issues.
Milestone

Comments

@CoffeeFlux
Copy link
Contributor

CoffeeFlux commented Feb 12, 2021

Some candidates:

  • MBR
  • EventPipe
  • Zlib

Specifics are still being figured out.

@CoffeeFlux CoffeeFlux added this to the 6.0.0 milestone Feb 12, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Feb 12, 2021
@lambdageek lambdageek removed the untriaged New issue has not been triaged by the area owner label Feb 13, 2021
@lambdageek
Copy link
Member

We're looking at various approaches. It won't necessarily be a separate workload pack.

@CoffeeFlux CoffeeFlux changed the title MBR is built into final published wasm output Split unnecessary libraries out from the primary wasm executable Feb 16, 2021
@CoffeeFlux CoffeeFlux changed the title Split unnecessary libraries out from the primary wasm executable Split unnecessary libraries out from the primary wasm blob Feb 16, 2021
@CoffeeFlux CoffeeFlux changed the title Split unnecessary libraries out from the primary wasm blob Avoid bundling unnecessary functionality in the wasm published output Feb 16, 2021
@CoffeeFlux CoffeeFlux added the size-reduction Issues impacting final app size primary for size sensitive workloads label Feb 16, 2021
@ghost
Copy link

ghost commented Feb 16, 2021

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @tannergooding, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

Some candidates:

  • MBR
  • Zlib

Specifics are still being figured out.

Author: CoffeeFlux
Assignees: steveisok, lambdageek
Labels:

area-Build-mono, size-reduction

Milestone: 6.0.0

@CoffeeFlux CoffeeFlux added the arch-wasm WebAssembly architecture label Feb 16, 2021
@ghost
Copy link

ghost commented Feb 16, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Some candidates:

  • MBR
  • Zlib

Specifics are still being figured out.

Author: CoffeeFlux
Assignees: steveisok, lambdageek
Labels:

arch-wasm, area-Build-mono, size-reduction

Milestone: 6.0.0

@marek-safar marek-safar added the tracking This issue is tracking the completion of other related issues. label Feb 17, 2021
@lewing
Copy link
Member

lewing commented Feb 25, 2021

zlib is used by the runtime for embedded pdbs so any solution here would need to handle that.

@CoffeeFlux
Copy link
Contributor Author

CoffeeFlux commented Feb 25, 2021

I believe we came to the conclusion that we might be willing to give that up for published release apps if it results in a substantial size reduction.

@CoffeeFlux
Copy link
Contributor Author

Components tracking issue: #50862

@lewing lewing modified the milestones: 6.0.0, Future Jul 14, 2021
@lewing
Copy link
Member

lewing commented Feb 9, 2024

This was resolved with the debugger component split

@lewing lewing closed this as completed Feb 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono size-reduction Issues impacting final app size primary for size sensitive workloads tracking This issue is tracking the completion of other related issues.
Projects
None yet
Development

No branches or pull requests

5 participants