Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StartInfo_NotepadWithContent* tests are failing in CI #44239

Closed
wfurt opened this issue Nov 4, 2020 · 7 comments · Fixed by #44972
Closed

StartInfo_NotepadWithContent* tests are failing in CI #44239

wfurt opened this issue Nov 4, 2020 · 7 comments · Fixed by #44972
Labels
Milestone

Comments

@wfurt
Copy link
Member

wfurt commented Nov 4, 2020

We have 348 failures in last 30 days. This is predominately on server20h1 queue:

Assert.StartsWith() Failure:\r\nExpected: StartInfo_NotepadWithContent_withArgumentList_1156_a34ea3f3\r\nActual:   
   at System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_NotepadWithContent_withArgumentList(Boolean useShellExecute) in /_/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs:line 1179

there are few other failures where this fails on various Windows 8-10 with

System.InvalidOperationException : Failed to set the specified COM apartment state.
   at System.Threading.Thread.SetApartmentState(ApartmentState state) in /_/src/libraries/System.Private.CoreLib/src/System/Threading/Thread.cs:line 238
   at System.Diagnostics.Process.ShellExecuteHelper.ShellExecuteOnSTAThread() in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Win32.cs:line 169
   at System.Diagnostics.Process.StartWithShellExecuteEx(ProcessStartInfo startInfo) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Win32.cs:line 79
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Win32.cs:line 24
   at System.Diagnostics.Process.Start() in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs:line 1234
   at System.Diagnostics.Process.Start(ProcessStartInfo startInfo) in /_/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.cs:line 1302
   at System.Diagnostics.Tests.ProcessStartInfoTests.StartInfo_NotepadWithContent_withArgumentList(Boolean useShellExecute) in /_/src/libraries/System.Diagnostics.Process/tests/ProcessStartInfoTests.cs:line 1169
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture) in /_/src/mono/netcore/System.Private.CoreLib/src/System/Reflection/RuntimeMethodInfo.cs:line 385
@ghost
Copy link

ghost commented Nov 4, 2020

Tagging subscribers to this area: @eiriktsarpalis, @jeffhandley
See info in area-owners.md if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Nov 4, 2020
@danmoseley
Copy link
Member

Those are different problems. In the first one, it's somehow not getting the window title (race?)

@danmoseley
Copy link
Member

@wfurt any sign of this diagnostic in the output (assuming there are failures on debug bits)

Debug.Assert(error == 0, $"Failed GetWindowTextLengthW(): { new Win32Exception(error).Message }");

Debug.Assert(error == 0, $"Failed GetWindowTextW(): { new Win32Exception(error).Message }");

@wfurt
Copy link
Member Author

wfurt commented Nov 4, 2020

not really, but I can look at more failures. I was wondering if the new queue even have Notepad :)

@danmoseley
Copy link
Member

Apparently it does as they got a Process object.

@danmoseley
Copy link
Member

The apartment state issue on non-Server Core occurred 10 times in 10/3-10/8 and not once previously or subsequently looking back 6 months. So I believe it was something elsewhere that is now fixed.

#44972 will fix both for Server Core.

@danmoseley
Copy link
Member

Closing as I don't think we will take more action here.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants